aboutsummaryrefslogtreecommitdiffstats
path: root/README-maintainer
diff options
context:
space:
mode:
authorJay Berkenbilt <ejb@ql.org>2021-12-21 23:26:05 +0100
committerJay Berkenbilt <ejb@ql.org>2021-12-21 23:26:05 +0100
commit5b6cf45f8365562d805547b6ca774f2ba2a0c90f (patch)
tree7ecbe5debb3b88feddeb9453a1e9b053b05cefc8 /README-maintainer
parenteff911a94f70fd9fa85d9dd81af4d9bc86e9bd52 (diff)
downloadqpdf-5b6cf45f8365562d805547b6ca774f2ba2a0c90f.tar.zst
Cleanup TODO
Diffstat (limited to 'README-maintainer')
-rw-r--r--README-maintainer11
1 files changed, 10 insertions, 1 deletions
diff --git a/README-maintainer b/README-maintainer
index 3ca9caf7..aaa0a61c 100644
--- a/README-maintainer
+++ b/README-maintainer
@@ -110,7 +110,16 @@ CODING RULES
the shared library boundary.
* Put private member variables in PointerHolder<Members> for all
- public classes. Remember to use QPDF_DLL on ~Members().
+ public classes. Remember to use QPDF_DLL on ~Members(). Exception:
+ indirection through PointerHolder<Members> is expensive, so don't do
+ it for classes that are copied a lot, like QPDFObjectHandle and
+ QPDFObject.
+
+* Traversal of objects is expensive. It's worth adding some complexity
+ to avoid needless traversals of objects.
+
+* Avoid attaching too much metadata to objects and object handles
+ since those have to get copied around a lot.
RELEASE PREPARATION