aboutsummaryrefslogtreecommitdiffstats
path: root/README-maintainer
diff options
context:
space:
mode:
authorJay Berkenbilt <ejb@ql.org>2022-02-11 13:17:51 +0100
committerJay Berkenbilt <ejb@ql.org>2022-02-11 13:18:33 +0100
commit956a272d622af303859d7239c21272116c108b58 (patch)
treedf4530e0353c4ac721a705c4c4af7cb21b3bf559 /README-maintainer
parent4ff837f099c4594fbb95463ebfd6199051d0fa30 (diff)
downloadqpdf-956a272d622af303859d7239c21272116c108b58.tar.zst
Remove abs calls and pick correct floating point epsilon values (fixes #641)
Diffstat (limited to 'README-maintainer')
-rw-r--r--README-maintainer5
1 files changed, 5 insertions, 0 deletions
diff --git a/README-maintainer b/README-maintainer
index 76a4c59c..4b36cf14 100644
--- a/README-maintainer
+++ b/README-maintainer
@@ -98,6 +98,11 @@ CODING RULES
* Avoid atoi. Use QUtil::string_to_int instead. It does
overflow/underflow checking.
+* Avoid certain functions that tend to be macros or create compilation
+ errors on some platforms. Known cases: strcasecmp, abs. Avoid min
+ and max. If needed, std::min and std::max are okay to use in C++
+ code with <algorithm> included.
+
* Remember to avoid using `operator[]` with `std::string` or
`std::vector`. Instead, use `at()`. See README-hardening.md for
details.