aboutsummaryrefslogtreecommitdiffstats
path: root/TODO
diff options
context:
space:
mode:
authorJay Berkenbilt <ejb@ql.org>2022-02-05 14:15:07 +0100
committerJay Berkenbilt <ejb@ql.org>2022-02-05 17:24:56 +0100
commit5f3f78822b5d43e9b02082da5268d186ba7101c0 (patch)
treec7d2407df01e4c622371ad290f9681a5ae99a476 /TODO
parent88c3d556d552a94aa42eaa2fa43667952e123dc8 (diff)
downloadqpdf-5f3f78822b5d43e9b02082da5268d186ba7101c0.tar.zst
Improve use of std::unique_ptr
* Use unique_ptr in place of shared_ptr in some cases * unique_ptr for arrays does not require a custom deleter * use std::make_unique (c++14) where possible
Diffstat (limited to 'TODO')
-rw-r--r--TODO10
1 files changed, 10 insertions, 0 deletions
diff --git a/TODO b/TODO
index 222e200a..8166f090 100644
--- a/TODO
+++ b/TODO
@@ -1,6 +1,9 @@
10.6
====
+* Expose emptyPDF to the C API. Ensure that qpdf_get_qpdf_version is
+ always static.
+
* Consider doing one big commit to reformat the entire codebase using
clang-format or a similar tool. Consider using blame.ignoreRevsFile
or similar (or otherwise study git blame to see how to minimize the
@@ -364,6 +367,13 @@ auto x_ph = std::make_shared<X>(); X* x = x_ph.get();
Derived* x = new Derived(); PointerHolder<Base> x_ph(x) -->
Derived* x = new Derived(); auto x_ph = std::shared_pointer<Base>(x);
+Also remember
+
+auto x = std::shared_ptr(new T[5], std::default_delete<T[]>())
+vs.
+auto x = std::make_unique<T[]>(5)
+
+
PointerHolder in public API:
QUtil::read_file_into_memory(