diff options
| author | Jay Berkenbilt <ejb@ql.org> | 2022-04-10 14:17:35 +0200 |
|---|---|---|
| committer | Jay Berkenbilt <ejb@ql.org> | 2022-04-10 22:52:36 +0200 |
| commit | 90cfe80bacdd0d398631afce76c4182e08cc78b9 (patch) | |
| tree | 369c3b9dfb0f8f8dac6181267b843934e976e40a /TODO | |
| parent | 8c504c9a905dc1cddbcbb32b368afe91f340984f (diff) | |
| download | qpdf-90cfe80bacdd0d398631afce76c4182e08cc78b9.tar.zst | |
Clean up/fix DLL.h
* Change DLL_EXPORT to libqpdf_EXPORTS (internal to the build). The
new name is cmake's default, is more conventional, and is less
likely to clash with other symbols.
* Add QPDF_DLL_PRIVATE for non-Windows
* Make logic around when to define QPDF_DLL et al more explicit
* Add detailed comments
Diffstat (limited to 'TODO')
| -rw-r--r-- | TODO | 3 |
1 files changed, 0 insertions, 3 deletions
@@ -37,9 +37,6 @@ cmake ===== * DLL.h - * Change DLL_EXPORT to QPDF_EXPORT. Be sure to call attention to - this in the release notes. There should be a "migrating to cmake" - in the manual, and ./configure should draw attention to it. * The effect of QPDF_DLL_CLASS is to export everything in the class, not just the vtable. On MSVC, we don't need this as the vtable gets exported automatically when needed. With gcc, we need it to |