aboutsummaryrefslogtreecommitdiffstats
path: root/TODO
diff options
context:
space:
mode:
authorJay Berkenbilt <ejb@ql.org>2022-09-08 17:06:15 +0200
committerJay Berkenbilt <ejb@ql.org>2022-09-08 17:06:15 +0200
commitc7a4967d10fb9688f235baa8e57a1fb578f5387d (patch)
treeb14956a2371befbd30b2a43583c390bc170ccd3d /TODO
parentdba61da1bfb7e4d74c723f369d1c017df9707a14 (diff)
downloadqpdf-c7a4967d10fb9688f235baa8e57a1fb578f5387d.tar.zst
Change reset to disconnect and clarify comments
I decided that it's actually fine to copy a direct object to another QPDF. Even if we eventually prevent a QPDFObject from having multiple parents, this could happen if an object is moved.
Diffstat (limited to 'TODO')
-rw-r--r--TODO11
1 files changed, 1 insertions, 10 deletions
diff --git a/TODO b/TODO
index 6f491dff..8c647fe5 100644
--- a/TODO
+++ b/TODO
@@ -785,7 +785,7 @@ Rejected Ideas
and too much toil for library users to be worth the small benefit of
not having to call resetObjGen in QPDF's destructor.
-* Fix Multiple Direct Object Owner Issue
+* Fix Multiple Direct Object Parent Issue
These are some ideas I had before m-holger's changes to split
QPDFValue from QPDFObject. These notes were written prior to the
@@ -811,12 +811,3 @@ Rejected Ideas
Note that arrays and dictionaries still need to contain
QPDFObjectHandle because of indirect objects. This only pertains to
direct objects, which are always "resolved" in QPDFObjectHandle.
-
- If this is addressed, read comments in the following places:
- * QPDFWriter.cc::enqueueObject near the call to getOwningQPDF
- * QPDFValueProxy::reset and QPDFValueProxy::destroy
- * QPDF::~QPDF()
- * test 92 in test_driver.cc
- * QPDFObjectHandle.hh near isDestroyed
- All these references were from the release of qpdf 11 (in case they
- have moved by such time as this might be resurrected).