aboutsummaryrefslogtreecommitdiffstats
path: root/libqpdf/Pl_RC4.cc
diff options
context:
space:
mode:
authorJay Berkenbilt <ejb@ql.org>2018-08-12 18:58:39 +0200
committerJay Berkenbilt <ejb@ql.org>2018-08-12 18:58:39 +0200
commitb6e414b10b3ae7b28ad16da2027106ec59a99a0a (patch)
treececd3bb38d43af6d4fa687414d2565e71c0ac206 /libqpdf/Pl_RC4.cc
parent4a4736c6954ab17d923a6d2968f34a33e09d714f (diff)
downloadqpdf-b6e414b10b3ae7b28ad16da2027106ec59a99a0a.tar.zst
Remove some extraneous null pointer checks (fixes #234)
There were a few places in the code that were checking that a pointer wasn't null before deleting it, even though C++ has always allowed delete 0. Most of the code did not perform these checks.
Diffstat (limited to 'libqpdf/Pl_RC4.cc')
-rw-r--r--libqpdf/Pl_RC4.cc14
1 files changed, 4 insertions, 10 deletions
diff --git a/libqpdf/Pl_RC4.cc b/libqpdf/Pl_RC4.cc
index 87c17f83..407490ca 100644
--- a/libqpdf/Pl_RC4.cc
+++ b/libqpdf/Pl_RC4.cc
@@ -13,11 +13,8 @@ Pl_RC4::Pl_RC4(char const* identifier, Pipeline* next,
Pl_RC4::~Pl_RC4()
{
- if (this->outbuf)
- {
- delete [] this->outbuf;
- this->outbuf = 0;
- }
+ delete [] this->outbuf;
+ this->outbuf = 0;
}
void
@@ -47,10 +44,7 @@ Pl_RC4::write(unsigned char* data, size_t len)
void
Pl_RC4::finish()
{
- if (this->outbuf)
- {
- delete [] this->outbuf;
- this->outbuf = 0;
- }
+ delete [] this->outbuf;
+ this->outbuf = 0;
this->getNext()->finish();
}