Merge pull request #982 from m-holger/cltidy

Apply various Clang-Tidy rules

1 files changed, 7 insertions, 8 deletions

diff --git a/libqpdf/QPDFNumberTreeObjectHelper.cc b/libqpdf/QPDFNumberTreeObjectHelper.cc
index 95cee9c8..478a1884 100644
--- a/libqpdf/QPDFNumberTreeObjectHelper.cc
+++ b/libqpdf/QPDFNumberTreeObjectHelper.cc
@@ -35,7 +35,7 @@ namespace
 
 static NumberTreeDetails number_tree_details;
 
-QPDFNumberTreeObjectHelper::~QPDFNumberTreeObjectHelper()
+QPDFNumberTreeObjectHelper::~QPDFNumberTreeObjectHelper() // NOLINT (modernize-use-equals-default)
 {
     // Must be explicit and not inline -- see QPDF_DLL_CLASS in README-maintainer. For this specific
     // class, see github issue #745.
@@ -56,8 +56,7 @@ QPDFNumberTreeObjectHelper::QPDFNumberTreeObjectHelper(
 QPDFNumberTreeObjectHelper
 QPDFNumberTreeObjectHelper::newEmpty(QPDF& qpdf, bool auto_repair)
 {
-    return QPDFNumberTreeObjectHelper(
-        qpdf.makeIndirectObject("<< /Nums [] >>"_qpdf), qpdf, auto_repair);
+    return {qpdf.makeIndirectObject("<< /Nums [] >>"_qpdf), qpdf, auto_repair};
 }
 
 QPDFNumberTreeObjectHelper::iterator::iterator(std::shared_ptr<NNTreeIterator> const& i) :
@@ -137,33 +136,33 @@ QPDFNumberTreeObjectHelper::iterator::remove()
 QPDFNumberTreeObjectHelper::iterator
 QPDFNumberTreeObjectHelper::begin() const
 {
-    return iterator(std::make_shared<NNTreeIterator>(m->impl->begin()));
+    return {std::make_shared<NNTreeIterator>(m->impl->begin())};
 }
 
 QPDFNumberTreeObjectHelper::iterator
 QPDFNumberTreeObjectHelper::end() const
 {
-    return iterator(std::make_shared<NNTreeIterator>(m->impl->end()));
+    return {std::make_shared<NNTreeIterator>(m->impl->end())};
 }
 
 QPDFNumberTreeObjectHelper::iterator
 QPDFNumberTreeObjectHelper::last() const
 {
-    return iterator(std::make_shared<NNTreeIterator>(m->impl->last()));
+    return {std::make_shared<NNTreeIterator>(m->impl->last())};
 }
 
 QPDFNumberTreeObjectHelper::iterator
 QPDFNumberTreeObjectHelper::find(numtree_number key, bool return_prev_if_not_found)
 {
     auto i = m->impl->find(QPDFObjectHandle::newInteger(key), return_prev_if_not_found);
-    return iterator(std::make_shared<NNTreeIterator>(i));
+    return {std::make_shared<NNTreeIterator>(i)};
 }
 
 QPDFNumberTreeObjectHelper::iterator
 QPDFNumberTreeObjectHelper::insert(numtree_number key, QPDFObjectHandle value)
 {
     auto i = m->impl->insert(QPDFObjectHandle::newInteger(key), value);
-    return iterator(std::make_shared<NNTreeIterator>(i));
+    return {std::make_shared<NNTreeIterator>(i)};
 }
 
 bool