In shippable code, favor smart pointers (fixes #235)

Use PointerHolder in several places where manually memory allocation
and deallocation were being used. This helps to protect against memory
leaks when exceptions are thrown in surprising places.

1 files changed, 3 insertions, 4 deletions

diff --git a/zlib-flate/zlib-flate.cc b/zlib-flate/zlib-flate.cc
index 9d4a62e2..d1c74d4d 100644
--- a/zlib-flate/zlib-flate.cc
+++ b/zlib-flate/zlib-flate.cc
@@ -61,8 +61,9 @@ int main(int argc, char* argv[])
 
     QUtil::binary_stdout();
     QUtil::binary_stdin();
-    Pl_StdioFile* out = new Pl_StdioFile("stdout", stdout);
-    Pl_Flate* flate = new Pl_Flate("flate", out, action);
+    PointerHolder<Pl_StdioFile> out = new Pl_StdioFile("stdout", stdout);
+    PointerHolder<Pl_Flate> flate =
+        new Pl_Flate("flate", out.getPointer(), action);
 
     try
     {
@@ -81,8 +82,6 @@ int main(int argc, char* argv[])
 	    }
 	}
 	flate->finish();
-	delete flate;
-	delete out;
     }
     catch (std::exception& e)
     {